-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LTI documentation to correct URLs for redirect #2184
Conversation
… doesn't have ending forward-slashes. Also update README.md commands for documentation to use python3 -m infront of mkdocs
WalkthroughWalkthroughThe modifications involve updating the commands for running and deploying documentation using MkDocs and standardizing URL formatting in the LTI integration JSON configuration. The command for serving documentation is changed to explicitly use Python 3, while trailing slashes are removed from specific URLs in the LTI integration to ensure proper endpoint resolution. Changes
Assessment against linked issues
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Files skipped from review due to trivial changes (1)
Additional comments not posted (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update
target_link_uri
,oidc_initiation_url
in LTI integration pages so that the examples doesn't have ending forward-slashes.Also update README.md commands for documentation to use
python3 -m
in front ofmkdocs
commands. This command is more likely to work out of the box compared to justmkdocs
Description
Motivation and Context
Closes #2179
How Has This Been Tested?
Run the documentation server locally, see the following for example configuration where url/uris don't have ending forward-slashes