Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display start and due date-time for assessment according to system timezone #2170

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

ecwu
Copy link
Contributor

@ecwu ecwu commented Jul 4, 2024

Description

As described in #2169, the displayed date-time is not in the correct timezone as the system. This change convert the date object to the local time zone before formatting it into a string.

Motivation and Context

To resolve this, I adjusted the date_to_s method in models/assessment.rb to utilize the getlocal method, which should fetch the system's timezone. This ensures the date and time are displayed correctly according to the system's local timezone.

How Has This Been Tested?

I have tested this fix on my end with system time zone set to Asia/Shanghai, and the date and time are now displayed correctly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop and erblint for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

Other issues / help required

If unsure, feel free to submit first and we'll help you along.

Copy link
Contributor

coderabbitai bot commented Jul 4, 2024

Walkthrough

Walkthrough

The Assessment model's date_to_s method has been updated to apply the getlocal method to the date object before formatting it. This change ensures that dates are adjusted to the local timezone before being converted to a string, potentially affecting how dates are displayed in various parts of the application.

Changes

File Change Summary
app/models/assessment.rb Modified date_to_s method to use getlocal on the date object before formatting it.

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4acee6c and a4a95e0.

Files selected for processing (1)
  • app/models/assessment.rb (1 hunks)
Additional comments not posted (1)
app/models/assessment.rb (1)

433-433: LGTM! But verify the function usage in the codebase.

The code changes are approved.

However, ensure that all function calls to date_to_s correctly handle the new behavior of adjusting the date to the system's local timezone.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@damianhxy damianhxy requested review from a team and 20wildmanj and removed request for a team July 14, 2024 04:20
@20wildmanj
Copy link
Contributor

I was unable to recreate the issue on my end (the timezones were correct previously), but I don't see any issues with the changes provided. LGTM

@20wildmanj 20wildmanj added this pull request to the merge queue Jul 25, 2024
Merged via the queue into autolab:master with commit b6a4387 Jul 25, 2024
5 checks passed
20wildmanj added a commit that referenced this pull request Jul 25, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assessment times are not displayed in the correct timezone on course homepage and specific course page.
2 participants