-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make moss page for current course only #1863
Make moss page for current course only #1863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that MOSS still works, changes work as expected on course with assessments / no assessments.
Left a few nits, but otherwise lgtm!
@damianhxy, resolved all the nits, let me know if anything else needs addressing! |
LGTM. Thanks again for the PR! |
Hi @damianhxy, sorry to go back to this, but I just had a thought that a very usual use case in subsequent runs for a course is to run plagiarism against previous runs of that course. Do you think my work here:
should be reverted? |
That's also a thought that I had. However, I don't think that's necessary, files from previous iterations can be uploaded via the additional files tar for comparison |
@umar221b On second thoughts, we had an instructor today request this previous ability to compare across semesters. Would it be difficult to revert this change? |
It should not be, let me try to work on something over the weekend. |
This has been resolved by #2015 |
Terribly sorry I did not get a chance to work on this. |
No worries, thank you for all your contributions! |
Description
a
variable inviews/courses/moss.html.erb
.Motivation and Context
Fixes #1861 in addition to making the page for the current course only, which makes more sense as the page is opened within a course's context.
How Has This Been Tested?
Tested locally on the latest docker images.
Here is how the page looks when there is at least 1 assessment:
And here is how it looks when there are no assessments:
I also submitted a few submissions to moss confirm nothing broke there.
Types of changes