Exception Notifications for no-view routes #510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dlbucci What's the state of this PR, does it work? How can I test it? |
|
It should work/shouldn't have a noticeable effect, except we'll get error emails and messages. You can probably test that handin and autograding still works by pulling this to staging and testing there. |
|
Can we also get this into v1.7.0? |
|
PING |
|
Deprecated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #491
This mucks with handin and autograding code, so test it out. I checked and regular handins seemed to work fine with autograded assessments using polling for the autograding. We should test the autograde_done callback on staging.