-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We should be notified if no-view routes fail #491
Comments
@droh @cg2v @devanshk @zyx-billy this seems to be related to the log_submit silent failure issue with 15-122 |
#510 was the fix to this problem. Why was it closed as deprecated? It should still apply to 2.0. |
Not sure if log_submit is still being developed / used. Let me know if this is still an issue |
I know local_submit is still used at Carnegie Mellon. I get occasional error notifications about local_submit being used when an assignment is no longer accepting submissions, and there is an issue with the shared AFS space some courses are using not being cleaned up at the end of the semester. Sites that do not have AFS cannot use local_submit as far as I know. It probably makes sense to have some of these errors logged to the COURSE_LOGGER. I don't believe it makes sense to use ExceptionNotifier in more cases than it already is Deprecating local_submit in favor of cli/API submit probably makes sense, but somebody has to convince the faculty to change their practices. |
Specifically, local_submit, log_submit, and autograde_done should be sending us emails if they fail, which doesn't happen because we (correctly) catch the errors before the global render_error function is called.
The text was updated successfully, but these errors were encountered: