Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should be notified if no-view routes fail #491

Open
dlbucci opened this issue Apr 28, 2015 · 4 comments
Open

We should be notified if no-view routes fail #491

dlbucci opened this issue Apr 28, 2015 · 4 comments

Comments

@dlbucci
Copy link
Member

dlbucci commented Apr 28, 2015

Specifically, local_submit, log_submit, and autograde_done should be sending us emails if they fail, which doesn't happen because we (correctly) catch the errors before the global render_error function is called.

@rmzr7
Copy link
Contributor

rmzr7 commented Oct 13, 2016

@droh @cg2v @devanshk @zyx-billy this seems to be related to the log_submit silent failure issue with 15-122

@zyx-billy
Copy link
Member

#510 was the fix to this problem. Why was it closed as deprecated? It should still apply to 2.0.
It would be really helpful if we can get all the error handling code into our handin & autograding routines.

@victorhuangwq
Copy link
Contributor

Not sure if log_submit is still being developed / used. Let me know if this is still an issue

@cg2v
Copy link
Member

cg2v commented Jun 18, 2020

I know local_submit is still used at Carnegie Mellon. I get occasional error notifications about local_submit being used when an assignment is no longer accepting submissions, and there is an issue with the shared AFS space some courses are using not being cleaned up at the end of the semester.

Sites that do not have AFS cannot use local_submit as far as I know.

It probably makes sense to have some of these errors logged to the COURSE_LOGGER. I don't believe it makes sense to use ExceptionNotifier in more cases than it already is

Deprecating local_submit in favor of cli/API submit probably makes sense, but somebody has to convince the faculty to change their practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants