Add debug builds to CI #36
Conversation
|
Warning Rate Limit Exceeded@damianhxy has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 35 minutes and 49 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates aim to enhance the CMake multi-platform workflow and build process. The workflow now supports both Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (5)
README.md (5)
Line range hint
13-13: Correct grammatical error in the description of CMake setup.The word "setup" should be "set up" when used as a verb.
- CMake is already setup to automatically handle acquiring and setting up rapidjson. + CMake is already set up to automatically handle acquiring and setting up rapidjson.
Line range hint
15-15: Simplify language for clarity.Consider using "before" instead of "prior to" for simplicity and ease of reading.
- Please make sure openssl and libcurl libraries are installed prior to building. + Please make sure openssl and libcurl libraries are installed before building.
Line range hint
28-28: Correct grammatical error in the description of the redirect URI.Remove the redundant possessive pronoun "the" before "your".
- The `redirect_uri` should be `<host>/device_flow_auth_cb` since this application uses the `device_flow` authorization method, where `<host>` is the your Autolab domain. + The `redirect_uri` should be `<host>/device_flow_auth_cb` since this application uses the `device_flow` authorization method, where `<host>` is your Autolab domain.
Line range hint
46-46: Clarify the description of the install script.The phrase "install script" is somewhat ambiguous as "install" is typically a verb. Consider rephrasing for clarity.
- We've written an install script that builds the entire project, installs the binary to your system, and installs the bash autocompletion script. + We've written a script that installs the entire project, places the binary on your system, and sets up the bash autocompletion script.
Line range hint
62-62: Correct the grammatical structure involving the command 'cd'.The use of 'cd' as a verb should be clarified for better readability.
- After installing manually, users can cd out of build and execute the following commands: + After installing manually, users can exit the build directory and execute the following commands:
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range and nitpick comments (8)
README.md (8)
Line range hint
13-13: Correct the verb form for setting up dependencies.- CMake is already setup to automatically handle acquiring and setting up rapidjson. + CMake is already set up to automatically handle acquiring and setting up rapidjson.
Line range hint
15-15: Simplify language for clarity.- Please make sure openssl and libcurl libraries are installed prior to building. + Please make sure openssl and libcurl libraries are installed before building.
Line range hint
22-22: Simplify language to enhance readability.- The program requires client credentials in order to build. + The program requires client credentials to build.
Line range hint
28-28: Correct grammatical error.- where `<host>` is the your Autolab domain. + where `<host>` is your Autolab domain.
Line range hint
46-46: Correct the incorrect use of "install" as a noun.- We've written an install script that builds the entire project, + We've written an installation script that builds the entire project,
Line range hint
46-46: Simplify language to enhance readability.- It needs sudo access in order to copy files to protected directories (details below) + It needs sudo access to copy files to protected directories (details below)
Line range hint
51-51: Correct punctuation error.- run `cmake ..`. + run `cmake ..`
Line range hint
62-62: Clarify the action for better understanding.- After installing manually, users can cd out of build and execute the following commands: + After installing manually, users can change directory (cd) out of build and execute the following commands:
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
This PR fixes the CI to correctly build release builds by changing the way that
CMAKE_BUILD_TYPEis handled.It also adds debug builds to the CI.
To check: view the CI checks and ensure that the correct build type is displayed under the "Configure CMake" task. You can also experiment with combinations of
-DCMAKE_BUILD_TYPEand-DRelease, but note thatCMAKE_BUILD_TYPEis cached.