Fix for assessment downloads over HTTP/2.0 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20wildmanj
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, assessment downloads do not work on AWS Autolab.
This is because the code checks for "Content-Disposition:" to determine if the file is downloadable.
While the header is usually spelt like that with HTTP/1.1, in HTTP/2.0 header names are converted to lowercase prior to encoding (https://stackoverflow.com/questions/5258977/are-http-headers-case-sensitive)
Local Autolab
AWS Autolab
This PR fixes this by also checking the lowercase version of content-disposition. A more complete solution might be to transform the entire header to lowercase before checking, but that seems unnecessary.