Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy loading of images #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tfriedel
Copy link

@tfriedel tfriedel commented Sep 4, 2023

use LazyLoadDict and shelve for detections to reduce memory consumption
supposed to go with roboflow/supervision#353

use LazyLoadDict and shelve for detections to reduce memory consumption
@tfriedel
Copy link
Author

tfriedel commented Sep 4, 2023

this may require other changes, like the dependencies would need to be updated to get the new supervision lib

@AlainPilon
Copy link

👀

@capjamesg capjamesg self-requested a review September 13, 2023 06:48
Copy link
Member

@capjamesg capjamesg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tfriedel Can you add the requisite dependency change to the requirements.txt when this feature is available in supervision? Aside from that, this looks good to me.

@tfriedel
Copy link
Author

@capjamesg sure, just ping me here when this happens

@capjamesg
Copy link
Member

@tfriedel Is the lazy loading API likely to be in the next release?

@tfriedel
Copy link
Author

@capjamesg no idea, I'm just an external contributor. If I get notified that the other PR is merged we can continue here.

@AChangXD
Copy link

@capjamesg Running into this issue as well, any idea on when this can be merged?

@KTXKIKI
Copy link

KTXKIKI commented Dec 27, 2023

How is the situation

@capjamesg
Copy link
Member

capjamesg commented May 20, 2024

@tfriedel Now that supervision supports the lazy loading functionality, are we ready to continue with this PR?

@tfriedel
Copy link
Author

@capjamesg sorry, this is too long ago now. I'm not using the library and have no interest in continuing to work on it at this time. But feel free to continue the work and make a new PR for example.

@SkalskiP
Copy link
Contributor

Hi @KTXKIKI, @capjamesg and @tfriedel 👋🏻
Work on datasets has had a lower priority in Supervision for some time, but it seems we can increase this priority in the coming weeks. The PR created by @tfriedel will definitely be a starting point for our work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants