Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up #5

Merged
merged 8 commits into from
May 30, 2022
Merged

Tidy up #5

merged 8 commits into from
May 30, 2022

Conversation

hwhmeikle
Copy link
Contributor

  • Rename export to AuthsignalBrowser.
  • Replace challengeWithRedirect and challengeWithPopup with a single challenge function that takes a mode parameter.
  • Inject a style tag that contains the CSS needed for the popup when using challenge({...config, mode: 'popup'). Previously the consumer had to add the CSS themselves.
  • Add a mfa method.
  • Remove unused vars/fix typos etc

chrisfisher
chrisfisher approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@chrisfisher chrisfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hwhmeikle hwhmeikle merged commit e332c20 into main May 30, 2022
@hwhmeikle hwhmeikle deleted the tidy-up branch May 30, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisfisher chrisfisher chrisfisher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hwhmeikle @chrisfisher