Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set an initial popup height #47

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Set an initial popup height #47

merged 2 commits into from
Nov 30, 2023

Conversation

hwhmeikle
Copy link
Contributor

To avoid seeing a scrollbar when the popup first opens.

@hwhmeikle
Set initial height on iframe to match skeleton
7a47229 
To reduce the changes of seeing a scrollbar on first load
@hwhmeikle
Bump version
e7c316a
LittleJono
LittleJono approved these changes Nov 30, 2023
View reviewed changes
Copy link

@LittleJono LittleJono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hwhmeikle hwhmeikle merged commit 0755f81 into main Nov 30, 2023
@hwhmeikle hwhmeikle deleted the initial-popup-height branch November 30, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleJono LittleJono LittleJono approved these changes

@justinsoong justinsoong Awaiting requested review from justinsoong

@chrisfisher chrisfisher Awaiting requested review from chrisfisher

@stevenclouston stevenclouston Awaiting requested review from stevenclouston

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hwhmeikle @LittleJono