Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AUT-1539] - Child Window Pop up option #46

Merged
merged 5 commits into from
Oct 29, 2023
Merged

[AUT-1539] - Child Window Pop up option #46

merged 5 commits into from
Oct 29, 2023

Conversation

justinsoong
Copy link
Contributor

@justinsoong justinsoong commented Oct 25, 2023 •
edited

  • Adds a new window pop up handler, width and height defaults to 400 x 500

@justinsoong justinsoong changed the title [WIP][AUT-1539] - Child Window Pop up option [AUT-1539] - Child Window Pop up option Oct 26, 2023
chrisfisher
chrisfisher reviewed Oct 26, 2023
View reviewed changes
src/authsignal.ts Outdated Show resolved Hide resolved
chrisfisher
chrisfisher approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@chrisfisher chrisfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@justinsoong justinsoong merged commit 135bd78 into main Oct 29, 2023
@justinsoong justinsoong deleted the AUT-1539-ChildWindow branch October 29, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisfisher chrisfisher chrisfisher approved these changes

@hwhmeikle hwhmeikle Awaiting requested review from hwhmeikle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justinsoong @chrisfisher @hwhmeikle