Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AUT-171] - Add onClose event handler + resolve promise when popup closes #12

Merged
merged 3 commits into from
Jul 26, 2022
Merged

[AUT-171] - Add onClose event handler + resolve promise when popup closes #12

merged 3 commits into from
Jul 26, 2022

Conversation

hwhmeikle
Copy link
Contributor

  • When using launch in popup mode, the promise will resolve when the popup closes.
  • Also now expose an onClose event that fires when the popup closes.

chrisfisher
chrisfisher approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@chrisfisher chrisfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 awesome - as discussed lets remove onClose from the api, otherwise 🚢

@hwhmeikle hwhmeikle merged commit e684b09 into main Jul 26, 2022
@hwhmeikle hwhmeikle deleted the expose-close-handler branch July 26, 2022 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisfisher chrisfisher chrisfisher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hwhmeikle @chrisfisher