[AUT-117] - Add modal support for enrolment #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwhmeikle
commented
Jul 21, 2022
| mfa(challenge: {mode?: "redirect"} & MfaInput): undefined; | ||
| mfa(challenge: {mode: "popup"} & MfaInput): Promise<boolean>; | ||
| mfa({mode, url}: MfaInput) { | ||
| if (mode === "popup") { |
There was a problem hiding this comment.
Had to do this if to make typescript happy due to function overload things
There was a problem hiding this comment.
Could potentially do a @ts-expect-error here instead
hwhmeikle
commented
Jul 21, 2022
| return new Promise<boolean>((resolve) => { | ||
| const onMessage = (event: MessageEvent) => { | ||
| if (event.origin === this.endpoint) { | ||
| if (event.data === AuthsignalWindowMessage.AUTHSIGNAL_CLOSE_POPUP) { |
There was a problem hiding this comment.
Only listening for the single message now, and never rejecting the promise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
challenge()andmfa()launch()authsignal-challenge-successandauthsignal-challenge-successevent listenerAuthsignalWindowMessage.AUTHSIGNAL_CLOSE_POPUPeventendpointoption so that we can verify event messages come from a trusted source