Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix declaration of expiresAt #874

Merged
merged 2 commits into from
Aug 21, 2023
Merged

fix declaration of expiresAt #874

merged 2 commits into from
Aug 21, 2023

Conversation

pnu
Copy link
Contributor

@pnu pnu commented May 11, 2023

Declaration of Auth0\WordPress\Cache\WpObjectCacheItem::expiresAt(?DateTimeInterface $expiration) must be compatible with Psr\Cache\CacheItemInterface::expiresAt(?DateTimeInterface $expiration): static

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Missing : static causes an fatal error. This was removed earlier in commit dc59a72

References

https://github.com/php-fig/cache/blob/master/src/CacheItemInterface.php#L89

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

Declaration of Auth0\WordPress\Cache\WpObjectCacheItem::expiresAt(?DateTimeInterface $expiration) must be compatible with Psr\Cache\CacheItemInterface::expiresAt(?DateTimeInterface $expiration): static
@pnu pnu requested a review from a team as a code owner May 11, 2023 14:34
@evansims evansims self-assigned this May 12, 2023
@evansims
Copy link
Member

Hey @pnu 👋 Thanks for raising this.

Let me investigate a little and see if I can figure out what's going on here that's triggering this error for you. My concern with the PR is that it would be a breaking change for sites with transient dependencies using PSR6 < 3.0, as typing wasn't introduced until that version.

Copy link
Member

@evansims evansims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@evansims evansims merged commit b9c326f into auth0:5.x Aug 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants