Update JWT library #576
Merged
Update JWT library #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7659cf9
to
f291df0
Compare
…gin; switch userinfo call to ID token
f291df0
to
1f389de
Compare
Codecov Report
@@ Coverage Diff @@
## master #576 +/- ##
============================================
+ Coverage 21.27% 21.33% +0.06%
+ Complexity 1313 1309 -4
============================================
Files 51 51
Lines 4278 4265 -13
============================================
Hits 910 910
+ Misses 3368 3355 -13
Continue to review full report at Codecov.
|
cocojoe
reviewed
Oct 31, 2018
| $userinfo_resp_code | ||
| ); | ||
| } | ||
| // Management API call failed, fallback to ID token. |
There was a problem hiding this comment.
What would be the expectation for a management API call to fail?
There was a problem hiding this comment.
If Client Credential Grant is turned off
|
Code is mostly the JWT Lib changes, thanks for adding you changed leeway as it's hard to tell if you changed anything vs changes that came from the update. That's a big jump in Majors from 2.0 to 5.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/userinfo, replace with ID tokenWP_Auth0_LoginManager::clean_id_token()InvalidArgumentExceptioncatching inWP_Auth0_LoginManager::init_auth0()WP_Auth0_LoginManager::implicit_login()(handled in calling method)References
Testing
No testing is in place for the login flow as it's highly coupled.