Improved code quality in WP_Auth0_LoginManager #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocojoe
reviewed
Apr 18, 2018
| @@ -61,38 +126,43 @@ public function login_auto() { | |||
| // Create the link to log in. | |||
| $login_url = 'https://' . $this->a0_options->get( 'domain' ) . | |||
| '/authorize?' . | |||
| 'scope=' . urlencode( $options['auth']['params']['scope'] ) . | |||
There was a problem hiding this comment.
For others reading: https://stackoverflow.com/questions/996139/urlencode-vs-rawurlencode
cocojoe
approved these changes
Apr 18, 2018
| * | ||
| * @see WP_Auth0_LoginManager::init() | ||
| */ | ||
| public function auth0_singlelogout_footer() { |
There was a problem hiding this comment.
you have changed the signature here, sneaky. This looks like an internal method though so fine.
There was a problem hiding this comment.
It's hooked to the wp_footer action, which does not pass any arguments to that function so that wasn't doing anything anyways. I was talking about this with @lbalmaceda, these callbacks have to be public to be hooked but I can't think of a use case where someone would call this directly, let alone have any use for an already non-functioning parameter.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very minimal functional changes, mostly comments.
urlencode->rawurlencodeperphpcssuggestion (RFC-compliant encoding, improves interoperability)die()->exitfor standardization (identical functionality)json_encode()towp_ json_encode()to catch more problematic encoding