Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 3.5.2 #399

Merged
merged 24 commits into from
Feb 28, 2018
Merged

Release 3.5.2 #399

merged 24 commits into from
Feb 28, 2018

Conversation

joshcanhelp
Copy link
Contributor

Release PR ready for review

@joshcanhelp
Fixed get_avatar hooked function to account for other user identifier…
2e2aa06 
…s besides a user ID (WP_User, WP_Comment, WP_Post, email); fixes #355
@joshcanhelp
Added field render function and fixed validation for migration IPs, f…
e406cf4 
…ixes #320
@joshcanhelp
Fixing XSS vulnerability in error_description; fixes #381
b197db6
@joshcanhelp
Adding all options and transients to delete; fixed #322
1bd0c05
@joshcanhelp
fixing wrong title and icon displayed when a widget is added with a s…
aed2c0e 
…eparate title and icon; fixes #269
@joshcanhelp
Better error messages using the method name magic constant
66a34e7
@joshcanhelp
Better empty default for error log array; docblock; fixes #285
37a128a
@joshcanhelp
Refactoring WP_Auth0_Api_Client::create_client() for better default U…
5ad1270 
…RL settings; fixing empty site title causing error in client creation; adding helper functions to WP_Auth0_Options for getting default client URL settings
@joshcanhelp
Removed client grant success message in log for initial setup; fixed …
e606f40 
…error message if WP_Error
@joshcanhelp
adjusting no protocol to null
f10e2be
@joshcanhelp
incorrect closing tag
a226f9c
@joshcanhelp
Fixed non-static method convertCertToPem called statically; fixes #380
fa66c66
@joshcanhelp
Fixing user migration setting validation throwing errors. Fixes #374
cc99216
@joshcanhelp
complete changelog in readme.txt pointing to github CHANGELOG
c28fcec
@joshcanhelp
better documentation on deprecated functions
87db497
@joshcanhelp
removed changelog entries older than 3.x; reverted convertCertToPem d…
bcf881c 
…eprecation
@joshcanhelp
renaming previous-deprecated function
dda8c11
@joshcanhelp
fixing Lock options sending an incorrect responseType, preventing SSO…
e661d6c 
… login; fixing incorrect redirect URL used for SSO; removing related but unused template; fixes #363
@joshcanhelp
removing outdated screenshot; updating repo readme to remove hook doc…
29f3db1 
…umentation (moving to auth0/docs) and point to more relevant documents
@joshcanhelp
removing duplicate documentation that exists on the WP.org readme
c46a264
cocojoe
cocojoe previously approved these changes Feb 19, 2018
View reviewed changes
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changelog

@joshcanhelp
Copy link
Contributor Author

Hold for #402

@joshcanhelp
Copy link
Contributor Author

@cocojoe - Merged in #402, ready for final review 👍

cocojoe
cocojoe previously approved these changes Feb 23, 2018
View reviewed changes
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Monster Fix release. 👍

@joshcanhelp
Copy link
Contributor Author

@cocojoe - Thank you!

Waiting on auth0/docs#5707 to merge and deploy.

@joshcanhelp joshcanhelp self-assigned this Feb 23, 2018
@joshcanhelp
Copy link
Contributor Author

@cocojoe - Updated the changelog which nuked your review. Can you reapprove this please and I'll release this tomorrow AM?

lbalmaceda
lbalmaceda approved these changes Feb 28, 2018
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@joshcanhelp joshcanhelp merged commit 9713e6a into master Feb 28, 2018
@joshcanhelp joshcanhelp deleted the release-3.5.2 branch February 28, 2018 18:09
@joshcanhelp joshcanhelp restored the release-3.5.2 branch February 28, 2018 18:17
@lbalmaceda lbalmaceda deleted the release-3.5.2 branch February 28, 2018 18:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

@cocojoe cocojoe cocojoe left review comments

Assignees

@joshcanhelp joshcanhelp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joshcanhelp @cocojoe @lbalmaceda