Improved setup wizard client create process #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
force-pushed
the
fixed-client-create-links
branch
from
e192050
to
d0c3f64
Compare
…RL settings; fixing empty site title causing error in client creation; adding helper functions to WP_Auth0_Options for getting default client URL settings
joshcanhelp
force-pushed
the
fixed-client-create-links
branch
from
0f95032
to
2ba3c50
Compare
…error message if WP_Error
joshcanhelp
force-pushed
the
fixed-client-create-links
branch
from
2ba3c50
to
66be3d0
Compare
|
@glena - Main thing here is just making sure I'm using the right default URLs in |
cocojoe
approved these changes
Feb 1, 2018
lib/WP_Auth0_Lock10_Options.php
Outdated
| $protocol = $this->_get_boolean( $this->wp_options->get( 'force_https_callback' ) ) ? 'https' : null; | ||
|
|
||
| return site_url( 'index.php?auth0=1', $protocol ); | ||
| $protocol = $this->_get_boolean( $this->wp_options->get( 'force_https_callback' ) ) ? 'https' : ''; |
There was a problem hiding this comment.
it is used later $site_url = empty( $protocol ) ? site_url( 'index.php' ) : site_url( 'index.php', $protocol );.
Honestly it is the same but would prefer null too
|
Please test 😄 Might be worth adding some basic tests at least to ensure all the various URL generators/modifiers are valid. |
glena
approved these changes
Feb 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WP_Auth0_Api_Client::create_client()to improve the URLs being saved by default and combine create with update (web_originscan now be pushed during create)WP_Auth0_DBManagerto grab correct links in the correct format