Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed migration IPs being saved #382

Merged
merged 1 commit into from
Jan 29, 2018
Merged

Conversation

joshcanhelp
Copy link
Contributor

No description provided.

@joshcanhelp joshcanhelp added this to the v3-Next milestone Jan 29, 2018
@@ -441,8 +445,8 @@ public function basic_validation( $old_options, $input ) {
if ( isset( $input['connections']['social_facebook_secret'] ) ) $input['connections']['social_facebook_secret'] = sanitize_text_field( $input['connections']['social_facebook_secret'] );
}

$input['migration_ips_filter'] = ( isset( $input['migration_ips_filter'] ) ? $input['migration_ips_filter'] : 0 );
$input['migration_ips'] = sanitize_text_field( $old_options['migration_ips'] );
$input['migration_ips_filter'] = ( ! empty( $input['migration_ips_filter'] ) ? 1 : 0 );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value of migration_ips_filter just used to be a boolean I take it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cocojoe - Boolean UX, yes. Technically integer, value="1" on the control

Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshcanhelp joshcanhelp merged commit e406cf4 into dev Jan 29, 2018
@joshcanhelp joshcanhelp deleted the fixed-migration-whitelist-ips branch January 29, 2018 16:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants