Fix use "self" outside class scope. #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WP_Auth0 class implement "insertAuth0Error" method. The function "get_currentauth0userinfo" is defined outside class, but it calls "insertAuth0Error" using "self" not "WP_Auth0".
|
Good catch! I will be releasing a new version soon (check the dev branch). It would be awesome if you can target this PR to this branch, if not, I will add it as soon I have some free time before the release. Thanks for your contribution. |
|
fixed on V.Next |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WP_Auth0 class implement
insertAuth0Errormethod.The function
get_currentauth0userinfois defined outside class, but it callsinsertAuth0ErrorusingselfnotWP_Auth0.