Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: Add a new config to allow people to access with the standar... #13

Merged
merged 4 commits into from
Sep 26, 2014

Conversation

glena
Copy link
Contributor

@glena glena commented Sep 23, 2014

...d WordPress login

The login form now shows a link that says "Login with WordPress username".
When the link is clicked it redirects to the same page but allowing the standard wordpress login and showing a link that says "Back to Auth0 login".

By default, this feature is enabled.

I didn't know if I may change the README.md file too so I keep it as it were.

@mgonto
Copy link
Contributor

mgonto commented Sep 23, 2014

Awesome.

It's working great :).

Just 2 minor comments:

  • Could we add some style to the Button? Maybe add a WP logo next to it so that it's a little more visible?
  • For some reason I see the Auth0 test button too far below, can we fix it? https://cloudup.com/cQOVNd_aP7w
  • If we add the Go to Wordpress button in the bottom, I'd add the Go back to Auth0 button at the bottom as well. What do you think about this one?

Cheers!

@glena
Copy link
Contributor Author

glena commented Sep 23, 2014

1 - do you mean to the link? I just wanted to mantain the same style as the default WP links. Let me check how it looks.
2 - Thats weird, let me check
3 - Can't.

@mgonto
Copy link
Contributor

mgonto commented Sep 23, 2014

1 - do you mean to the link? I just wanted to mantain the same style as the default WP links. Let me check how it looks.

I know, I figured, but it's almost hidden. Otherwise, let's keep it like this.

3 - Can't.

Why? Just so that I know.

@glena
Copy link
Contributor Author

glena commented Sep 23, 2014

1 - do you mean to the link? I just wanted to mantain the same style as the default WP links. Let me check how it looks.
I know, I figured, but it's almost hidden. Otherwise, let's keep it like this.

Will check and send a screenshot.

3 - Can't.
Why? Just so that I know.

As long I know (maybe I'm wrong) WP don't let you change the standard login. Thats why the plugin hides it and shows the A0 one. The A0 login template is redered on top of the standar login so I'm not able to change what is below it.
Anyway, I will research if there is a way to change the behaviour of this.

@mgonto
Copy link
Contributor

mgonto commented Sep 23, 2014

Cool.

Thanks for the answers :)

@glena
Copy link
Contributor Author

glena commented Sep 23, 2014

Ok, seems that we can add the link using the login_footer action :)

@mgonto
Copy link
Contributor

mgonto commented Sep 23, 2014

Ok, seems that we can add the link using the login_footer action :)

Awesome 💃

@glena
Copy link
Contributor Author

glena commented Sep 25, 2014

@mgonto, @woloski
what do you think about this? https://cloudup.com/cOQ3_9NLPF0

 code refactor
 add icon to the regular WP login
add an action to add the style on the header
@mgonto
Copy link
Contributor

mgonto commented Sep 25, 2014

Let's put the logo a little big smaller but it looks great :).

Thanks!

@rickyrauch
Copy link
Contributor

I think we don't need wp logo :)

@glena
Copy link
Contributor Author

glena commented Sep 25, 2014

I also think the same, it is better if this link is "discrete". ¯_(ツ)_/¯

@mgonto
Copy link
Contributor

mgonto commented Sep 25, 2014

Let's go without then. Sorry for the Twists and turns @glena

@glena
Copy link
Contributor Author

glena commented Sep 25, 2014

Thats ok, it could be worst :P

glena added a commit that referenced this pull request Sep 26, 2014
New feature: Add a new config to allow people to access with the standar...
@glena glena merged commit e9eb92e into master Sep 26, 2014
@glena glena deleted the allow-legacy-login branch September 26, 2014 00:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants