Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show widget when registrations are not allowed. #5

Closed
rickyrauch opened this issue Mar 13, 2014 · 11 comments
Closed

Don't show widget when registrations are not allowed. #5

rickyrauch opened this issue Mar 13, 2014 · 11 comments

Comments

@rickyrauch
Copy link
Contributor

No description provided.

@mgonto
Copy link
Contributor

mgonto commented Sep 23, 2014

Example? When are registrations not allows? How to reproduce? @gravityonmars

@glena
Copy link
Contributor

glena commented Oct 9, 2014

Why did you close this issue?

@mgonto mgonto reopened this Oct 9, 2014
@mgonto
Copy link
Contributor

mgonto commented Oct 9, 2014

Because you actually commited something. I thought that fixed it. DIdn't it?¡

@glena
Copy link
Contributor

glena commented Oct 9, 2014

No, I just get mixed up with the issues and when I realized the eror I
couldnt ammend the commit message.
Is there a way to add a WIP label to the issues?(I can't)

Germán G. Lena

@german_lena https://twitter.com/german_lena
http:https://germanlena.com.ar http:https://germanlena.com.ar

2014-10-09 15:21 GMT-03:00 Martin Gontovnikas [email protected]:

Because you actually commited something. I thought that fixed it. DIdn't
it?¡


Reply to this email directly or view it on GitHub
#5 (comment).

@mgonto
Copy link
Contributor

mgonto commented Oct 9, 2014

I just created the label. You should be able to put it now :)

@glena
Copy link
Contributor

glena commented Oct 9, 2014

Awesome :) <3

Germán G. Lena

@german_lena https://twitter.com/german_lena
http:https://germanlena.com.ar http:https://germanlena.com.ar

2014-10-09 15:35 GMT-03:00 Martin Gontovnikas [email protected]:

I just created the label. You should be able to put it now :)


Reply to this email directly or view it on GitHub
#5 (comment).

@glena glena added WIP and removed WIP labels Oct 10, 2014
@glena
Copy link
Contributor

glena commented Oct 10, 2014

I am not sure about this issue. Can you give me more info?

@glena
Copy link
Contributor

glena commented Oct 10, 2014

When the wordpress "Membership Anyone can register" setting is disabled, the widget should show only login capabilities (as when plugin's "Allow signup" is disabled)

@glena
Copy link
Contributor

glena commented Oct 10, 2014

ready on dev

@mgonto
Copy link
Contributor

mgonto commented Oct 15, 2014

If Anyone can register is checked, we should add the Signup button at the bottom. We should also always show the Reset at the bottom as well.

Set disableResetAction and disableSignupAction to false when that option is set.

@mgonto
Copy link
Contributor

mgonto commented Oct 15, 2014

The widget should be shown but not the Signup / Reset buttons.

The only problem is that I don't think we can restrict the automatic Signup via IdPs Login. @woloski any thoughts on that?

glena added a commit that referenced this issue Oct 16, 2014
… setting allow registration and merge it with standard WP setting, fixes for social login/registration, disable social registration if registration is disabled
@glena glena closed this as completed Oct 17, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants