Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to default domain also from aditional domain for different language #110

Closed
jakuub opened this issue Jan 8, 2016 · 7 comments
Closed

Comments

@jakuub
Copy link

jakuub commented Jan 8, 2016

Hello. We use multidomain install of wp with different domains for languages by WPML.

The problem here is, that when we want someone to login on different(www.mysite.sk) than default(www.mysite.com) domain, this will happen:

  1. user try to login on other domain (eg www.mysite.sk)
  2. the login form is showned
  3. user enter credentials
  4. user login successful
  5. user redirect to default domain (www.mysite.com)

This can be fixed by replacing site_url with home_url to stay on actual "domain" rather then change to default here:
https://github.com/auth0/wp-auth0/blob/master/templates/auth0-login-form.php#L52

This is other custom bugfix we needed, but I think, only needed edit is one described above and I hope it will not break something, but I think it shouldnt.

@jakuub
Copy link
Author

jakuub commented Jan 8, 2016

I want to admit, that the same problem ocures with SSO, but I think it is becouse $callbackURL is used in both.

@glena
Copy link
Contributor

glena commented Jan 8, 2016

yes, it is due to how $callbackURL is created as you said.

I think it make sense o user home_url but help me trying to figure out why it shouldnt...

I think it should work fine in every case right?

@jakuub
Copy link
Author

jakuub commented Jan 8, 2016

Yues, I think so. I don't see any problem with using home_url, I just didn't read the whole code, so I don't know all occurences.

@glena
Copy link
Contributor

glena commented Jan 8, 2016

I think just there. can you change it in your code for now? I will push the change for V.next in a couple of minutes

@jakuub
Copy link
Author

jakuub commented Jan 8, 2016

Thank you, I already changed it in my code, I just wanted to let you know, to idealy get it in to next release :-).

@glena
Copy link
Contributor

glena commented Jan 8, 2016

done! ☝️

thank you

@glena glena closed this as completed Jan 8, 2016
@jakuub
Copy link
Author

jakuub commented Jan 8, 2016

Thank you too :-).

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants