Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nice error message when exchange of token returns 401 #11

Closed
woloski opened this issue Sep 11, 2014 · 7 comments
Closed

add nice error message when exchange of token returns 401 #11

woloski opened this issue Sep 11, 2014 · 7 comments

Comments

@woloski
Copy link
Contributor

woloski commented Sep 11, 2014

right now it fails with the an empty message
we should show
"Please check your Client Secret on the settings plugin is the same as the one on the Auth0 dashboard"

@mgonto
Copy link
Contributor

mgonto commented Sep 23, 2014

To test it out, add a Rule to your Auth0 account that always returns callback(new UnauthorizedError('doesnt work'));

@mgonto mgonto added this to the 1.1.4 milestone Oct 9, 2014
@glena glena added the WIP label Oct 10, 2014
@glena
Copy link
Contributor

glena commented Oct 10, 2014

I will need the error message for all the possible reponses on the error_description field of the response to the call "oauth/token".

Also, what do you think about this? https://cloudup.com/c0CCRk5q1-y
It will autohide in 10 seconds or when the user clicks on close.

@glena
Copy link
Contributor

glena commented Oct 10, 2014

ready on dev

@mgonto
Copy link
Contributor

mgonto commented Oct 15, 2014

I still don't see a nice error: https://cloudup.com/c9X-XTW0BUI

@mgonto
Copy link
Contributor

mgonto commented Oct 15, 2014

I don't know exactly what @woloski meant.

What I tried is the following:

  • Create a Rule in my account that does the following:
returns callback(new UnauthorizedError('doesnt work'));
  • Try to Log in with anything. It'll fail.
  • There's an error shown in the URL but I don't see a nice popup or error message anywhere. We should show the user that there was an error logging in and redirect him again to the Login page in that case. This is what I got: https://cloudup.com/c2cGpim9jhr

@glena
Copy link
Contributor

glena commented Oct 15, 2014

That was my first idea (check https://cloudup.com/c0CCRk5q1-y) and asked for the messages to show for each error.

Now what it does is to show an error page when, we validate the code in the callback url, the WS returns 401 (in the case of misconfiguration of secret, etc).

@mgonto
Copy link
Contributor

mgonto commented Oct 15, 2014

I'm not sure what error @woloski is describing.

If you follow the steps I wrote down, you'll see that no error page is shown. If you want I can move that to a new issue, but IDK if this is the same. Can you clarify?

glena added a commit that referenced this issue Oct 16, 2014
…t manages the errores when there is no code and an error instead)
@glena glena closed this as completed Oct 17, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants