Add missing commas so that "use strict" works #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: jpaddison3 <[email protected]> When we experimented with adding "use strict" to our codebase in a way that accidentally covered all of `node_modules`, this file crashed on start because `crypto` is an assignment to an undeclared variable. It's an undeclared variable because the preceding line is missing a comma. Fix that, so that this file can pass `use strict`.
|
Anyone to merge that? Also needed on my side to be able to build with latest version of esbuild. |
frederikprijck
previously approved these changes
Aug 15, 2022
frederikprijck
approved these changes
Aug 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: jpaddison3 [email protected]
When we experimented with adding "use strict" to our codebase in a way that accidentally covered all of
node_modules, this file crashed on start becausecryptois an assignment to an undeclared variable. It's an undeclared variable because the preceding line is missing a comma. Fix that, so that this file can passuse strict.