Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jsonwebtoken is not a dev dependency #89

Merged
merged 1 commit into from
May 21, 2019

Conversation

simov
Copy link
Contributor

@simov simov commented May 11, 2019

Obviously 1.5.0 is broken.

@simov
Copy link
Contributor Author

simov commented May 12, 2019

Ok, I'll expand a little bit on this:

Since you published v1.5.0 a few days ago, your module now depends on jsonwebtoken because of the new passport integration. Your published module depends on jsonwebtoken, not your test suite.

Unless the consumer of this module have explicit dependency on jsonwebtoken or some of its other dependencies happens to have it installed under the root of the node_modules folder, their code will fail, because of the missing jsonwebtoken dependency required in the passport integration.

Hope that makes sense.

@damieng damieng merged commit 5939956 into auth0:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants