Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow JWT to not contain a "kid" value #55

Merged
merged 3 commits into from
Apr 8, 2020
Merged

Allow JWT to not contain a "kid" value #55

merged 3 commits into from
Apr 8, 2020

Conversation

dejan9393
Copy link
Contributor

Allow JWT to not contain a "kid" value when the JWKS endpoint only returns a single key.

The spec marks this claim as optional.

@stale
Copy link

stale bot commented Oct 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

@stale stale bot added closed:stale Issue or PR has not seen activity recently and removed closed:stale Issue or PR has not seen activity recently labels Oct 26, 2019
@stale
Copy link

stale bot commented Jan 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

@stale stale bot added the closed:stale Issue or PR has not seen activity recently label Jan 25, 2020
@dejan9393
Copy link
Contributor Author

bump

@stale stale bot removed the closed:stale Issue or PR has not seen activity recently label Jan 28, 2020
@dejan9393 dejan9393 mentioned this pull request Feb 10, 2020
Closed
@davidpatrick davidpatrick self-requested a review March 18, 2020 23:42
davidpatrick
davidpatrick suggested changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@davidpatrick davidpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Do you mind adding a test in jwksClient.tests.js to test for the scenario when JWKS endpoint returns a single key and no KID is provided

Thank you 🙏

tests/koa.tests.js Outdated Show resolved Hide resolved
@davidpatrick davidpatrick linked an issue Apr 3, 2020 that may be closed by this pull request
How does the library work for a token that doesn't have kid in header, but only x5t? #5
Closed
@davidpatrick davidpatrick self-assigned this Apr 3, 2020
@dejan9393 dejan9393 requested a review from a team April 7, 2020 00:51
@dejan9393 dejan9393 force-pushed the add-support-for-no-kid-when-single-key branch from 3768134 to 31c7f65 Compare April 7, 2020 01:27
@dejan9393
Copy link
Contributor Author

I've fixed that test up (+1 more with the same issue), rebased on top of master, and added a similar test to passport.test.js

@davidpatrick
Copy link
Contributor

Thank you for the quick follow up @dejan9393

@davidpatrick davidpatrick merged commit a3ba52e into auth0:master Apr 8, 2020
@davidpatrick davidpatrick added this to the v1-Next milestone Apr 8, 2020
@davidpatrick davidpatrick mentioned this pull request Apr 13, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request May 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpatrick davidpatrick davidpatrick approved these changes

Assignees

@davidpatrick davidpatrick

Labels
CH: Fixed
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

How does the library work for a token that doesn't have kid in header, but only x5t?
2 participants
@dejan9393 @davidpatrick