Add fastify integration

[Ethan-Arrowood]

Adds an integration for Fastify. I'll be adding unit tests tomorrow. Ref fastify/fastify-jwt#10 fastify/fastify-jwt#8

[lgomez]

Is there anything we can do to get this accepted and merged?

[Ethan-Arrowood]

I think this repo might not be very active haha

[cocojoe]

@Ethan-Arrowood thanks for the contribution, you mentioned some tests?

[Ethan-Arrowood]

Hi @cocojoe Ahh yes I did; I'll push some updates soon.

[sandrinodimattia]

Please also rebase your changes 👍

[cocojoe]

@Ethan-Arrowood any updates on this? Thx

[Ethan-Arrowood]

Hi apologies for the delay I had an incredible busy week finishing up final assignments for Uni. I'll try to hash this out today.

[Ethan-Arrowood]

Alright rebased and fixed some merge conflicts. Started working on tests. Not sure what I should be testing so I'm using the existing tests as a reference. I also don't think Fastify works in the supertest request() method so I gotta see what to do about that.

[degrammer]

Hi @Ethan-Arrowood we really appreciate this work, I was reviewing the integration of your changes with a local fastify server, since I don't have any experience with fastify, can you help us to clarify the implementation details and add it as an example on our examples directory ?
With this code I'm always getting this message: only RS256 is supported

const fastify = require('fastify')();
const fastifyJwt = require('fastify-jwt');
const jwksRsa = require('jwks-rsa');

fastify.post('/signup', (request, reply) => {
  reply.jwtSign(request.body, function (err, token) {
    return reply.send(err || { 'token': token })
  })
})

// Run the server!
const start = async () => {
  try {
    fastify.register(fastifyJwt, { 
      secret: jwksRsa.fastifyJwtSecret({
        jwksUri: 'http:https://localhost/.well-known/jwks.json'
      }),
      algorithms: ['RS256']
    })
    await fastify.listen(9000)
    fastify.log.info(`server listening on ${fastify.server.address().port}`)
  } catch (err) {
    fastify.log.error(err)
    process.exit(1)
  }
}
start()

[Ethan-Arrowood]

Will work on an example now.

[Ethan-Arrowood]

Okay I'm unsure how to mock a jwks locally, but this code should work. It is pretty much what you sent just the register block is moved to outside the start method. I was using this in a project a while back with Auth0 as well as some scoping authz functionality. The project went stagnant about 4-5 months ago so i don't know how well its working anymore. If this demo still doesn't work I'll see what I can make happen from scratch.

Sorry I've been touch and go with this PR. I pushed it to the back of my mind a while back, so now I'm just trying to remember how to get it all working again.

[degrammer]

Thank you @Ethan-Arrowood I will review it.

[vcanales]

Hi @Ethan-Arrowood we really appreciate this work, I was reviewing the integration of your changes with a local fastify server, since I don't have any experience with fastify, can you help us to clarify the implementation details and add it as an example on our examples directory ?
With this code I'm always getting this message: only RS256 is supported

Had the same issue, I had to add decode: { complete: true } to the options object to get the headers along with the payload of the token. This PR seems a bit stale, may I chime in with a working implementation? There's something else to consider in that the decode parameter is not returned if the token is invalid, so the "Only RS256 is supported" error is misleading in that case.

[vcanales]

@Ethan-Arrowood I've created a PR to your branch with suggested updates, I hope you have a chance to look at them. Also, please rebase this branch.

[Ethan-Arrowood]

@vcanales I'll go through this tonight! Thank you

[Ethan-Arrowood]

@vcanales looks like you made a pr to the master branch on my fork. Can you make your PR against the add-fastify branch on my fork instead please?

[Ethan-Arrowood]

I have rebased my branch against origin master. Currently awaiting changes from @vcanales

[vcanales]

I have rebased my branch against origin master. Currently awaiting changes from @vcanales

Done! Sorry for the confusion :)

[vcanales]

Hello, @degrammer! I think we've addressed your concerns on previous comments with the latest changes. It would be amazing if you could take some time to re-review this!

[dnlup]

Are there any news on this? Can I help in any way?

[vcanales]

Gone off my own way and created a fork:

• https://github.com/vcanales/fastify-authz-secret-provider
• https://www.npmjs.com/package/fastify-authz-jwks

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

[tnguyen14]

Thanks @vcanales for the fork. Would've been great if this work was integrated into this library.