Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #189
Currently, the examples directory is published in the npm package. This results in
jwks-rsa
being flagged withCVE-2020-15084
since the example included installs express-jwt. A simple solution to this is to addexamples
to.npmignore
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
In CI checks, consumers of the jwks-rsa node module will scan the resulting images for known security vulnerabilities and block deploys when packages with known vulnerabilities are discovered.
Complicating matters, some modules publish to NPM with "example" directories containing other packages that aren't needed at runtime. This practise stalls deployment pipelines and contributes unwanted files to runtime images.
jwks-rsa:1.5.1
was flagged for includingexpress-jwt:3.4.0
in the examples directory. This package was flagged for containingCVE-2020-15084
at path/usr/src/app/node_modules/jwks-rsa/examples/express-demo/node_modules/express-jwt
References
https://nvd.nist.gov/vuln/detail/CVE-2020-15084
Testing
Publish dry-run:
Checklist
master