Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure proxy with env vars #188

Merged
merged 2 commits into from
Oct 16, 2020

Conversation

lubomir-haralampiev
Copy link
Contributor

@lubomir-haralampiev lubomir-haralampiev commented Sep 25, 2020

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

This PR adds a missing part of the workaround for the axios issue with corporate proxies.
request and axios as well provide the possibility to define proxy config via the environment variables HTTP_PROXY, HTTPS_PROXY and NO_PROXY. Currently the request wrapper doesn't interpret these env vars and doesn't create the needed https-proxy-agent. As a result the axios internal proxy logic is applied which causes the problems with many corporate proxies.

This PR adds this missing functionality.

References

#144
axios/axios#2072

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@davidpatrick davidpatrick changed the title complete the axios workaround - read proxy condifuration from env vars if set Add ability to configure proxy with env vars Oct 16, 2020
@davidpatrick davidpatrick modified the milestones: v2-Next, v1-next Oct 16, 2020
@davidpatrick davidpatrick merged commit 273af8f into auth0:master Oct 16, 2020
@davidpatrick davidpatrick mentioned this pull request Oct 23, 2020
@davidpatrick davidpatrick removed this from the 1.12.0 milestone Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants