Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dependencies for --production flag with npm #180

Merged
merged 2 commits into from
Sep 24, 2020

Conversation

alexrqs
Copy link
Contributor

@alexrqs alexrqs commented Sep 23, 2020

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

this pr changes 2 devDependencies to actual dependencies to avoid the error mentioned on #179

"errorType": "Runtime.ImportModuleError",
"errorMessage": "Error: Cannot find module 'https-proxy-agent'",

References

this fixes #179

Testing

import as dependency and use npm install --production and should work fine

@alexrqs alexrqs requested a review from a team September 23, 2020 19:00
@NShahri NShahri mentioned this pull request Sep 24, 2020
4 tasks
@drsaeva
Copy link

drsaeva commented Sep 24, 2020

Please add a fix for this line:

https://github.com/auth0/node-jwks-rsa/blob/master/src/wrappers/request.js#L4

The http-proxy-agent should have been imported there, but is not, and is therefore a dead dependency.

@davidpatrick davidpatrick merged commit 4a3270b into auth0:master Sep 24, 2020
@davidpatrick davidpatrick added this to the 1.10.1 milestone Sep 24, 2020
@davidpatrick davidpatrick mentioned this pull request Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The release of 1.10.0 breaks the internet
4 participants