Update express-jwt ^6.0.0 #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davidpatrick
commented
Aug 8, 2020
davidpatrick
commented
- Updates express-jwt dep
- Fixes options sent to express-jwt
- Tests ✅
jimmyjames
reviewed
Aug 10, 2020
| @@ -161,7 +169,8 @@ describe('expressJwtSecret', () => { | |||
| cb(new Error('This is bad')); | |||
| } | |||
| } | |||
| }) | |||
| }), | |||
| algorithms: [ 'RS256' ] | |||
There was a problem hiding this comment.
are these changes to add the algorithms array required from the express-jwt upgrade? Just want to make sure it's not a breaking change.
There was a problem hiding this comment.
Yes, @jimmyjames. That's the actual breaking change announced in the last v6 of express-jwt (which we want to upgrade to). See the updated readme and the cve.
@davidpatrick Changes look good 👍
lbalmaceda
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.