Added timeout with default value of 30s #132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this pull request is to add a timeout (with default value) which applies to the request for fetching keys.
The introduction of the timeout setting isn't itself breaking but the default value of 30s could be considered breaking, though it should be a sane value that everyone could live with.
References
Issue #131
Testing
No tests have been added.
This change depends on the timeout functionality of the request lib.
Manual verification has been done and auto tests have been executed with npm test.
Checklist
master