Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jwks-rsa publishes examples to npm registry which causes security violations #189

Closed
anthony-telljohann opened this issue Oct 6, 2020 · 1 comment · Fixed by #190
Closed

jwks-rsa publishes examples to npm registry which causes security violations #189

anthony-telljohann opened this issue Oct 6, 2020 · 1 comment · Fixed by #190

Comments

@anthony-telljohann
Copy link

anthony-telljohann commented Oct 6, 2020 •
edited
Loading

Description

jwks-rsa publishes the examples directory to npm. The examples contain non-production code which security tools such as NexusIQ will scan and report vulnerabilities on which is the case with koa.
@richgerrard
Copy link
Contributor

We also consume you, and we are seeing CVE-2020-15084 flagged in our CI process because you are including express-jwt in your example directory:
Ex: /usr/src/app/node_modules/jwks-rsa/examples/express-demo/node_modules/express-jwt

It is imperative that you do not include dependencies in the example folder of your node module.

@richgerrard richgerrard mentioned this issue Oct 8, 2020
Merged
2 tasks
frederikprijck pushed a commit that referenced this issue Oct 8, 2020
@richgerrard
fix: do not publish examples to npm (#190)
872bc4d 
Closes: #189

Currently, the examples directory is published in the npm package. This results in `jwks-rsa` being flagged with `CVE-2020-15084` since the example included installs express-jwt. A simple solution to this is to add `examples` to `.npmignore`
@snyk-bot snyk-bot mentioned this issue Jan 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Do not publish examples
2 participants
@anthony-telljohann @richgerrard