Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use [REDACTED] instead of [SANITIZED] when cleaning errors #515

Merged
merged 3 commits into from
Jul 23, 2020
Merged

Use [REDACTED] instead of [SANITIZED] when cleaning errors #515

merged 3 commits into from
Jul 23, 2020

Conversation

jimmyjames
Copy link
Contributor

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage

Checklist

@jimmyjames jimmyjames requested a review from a team July 22, 2020 20:53
lbalmaceda
lbalmaceda reviewed Jul 22, 2020
View reviewed changes
test/errors.tests.js Outdated
@@ -28,11 +28,11 @@ describe('Errors', function() {
const sanitizedError = errors.sanitizeErrorRequestData(error);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to update these variables as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

test/errors.tests.js Outdated
@@ -101,7 +101,7 @@ describe('Errors', function() {
});

it('should sanitize the original error sensitive information', function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and the messages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

test/errors.tests.js Outdated
@@ -52,8 +52,8 @@ describe('Errors', function() {
const sanitizedError = errors.sanitizeErrorRequestData(error);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

lbalmaceda
lbalmaceda approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if you want to update the test descriptions, properties, and functions that are still using the word sanitize. As long as they are not exported in the lib you could. Not a blocker 👍

@jimmyjames
Copy link
Contributor Author

I don't know if you want to update the test descriptions, properties, and functions that are still using the word sanitize. As long as they are not exported in the lib you could. Not a blocker 👍

Makes sense to update it now; pushed a new commit to do that.

@jimmyjames jimmyjames merged commit bde5148 into master Jul 23, 2020
@jimmyjames jimmyjames modified the milestones: v2Next, v2.27.1 Jul 23, 2020
@jimmyjames jimmyjames mentioned this pull request Jul 23, 2020
Merged
3 tasks
@evansims evansims deleted the change-term branch June 13, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
CH: Changed tiny Tiny review
Projects
None yet
Milestone
v2.27.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmyjames @lbalmaceda