Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the cookie set is always Secure unless running on localhost or when
NODE_ENV
is notproduction
.When deploying code to a non-https site that has
NODE_ENV=production
, setting the cookie will fail.Our use-case is deploying PRs to a dynamically created environment, where we test that everything is working as in production (thus, we have
NODE_ENV=production
), but the environment is a random url, and so cannot have https (at least easily).The proposed solution is to allow setting an environment variable that turns off setting the cookie as secure,
AUTH0_ALLOW_INSECURE_COOKIE=true
Testing
Checklist
master