Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up erroneous cookies when chunk size decreases #1300

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

adamjmcgrath
Copy link
Contributor

📋 Changes

When a session is updated it might decrease in size. If the session is large and split into several cookies, the number of cookies could reduce (e.g. from 3 to 2), in these cases the 3rd cookie needs to be deleted

📎 References

fixes #1293

(this code is taken from the Beta)

@adamjmcgrath adamjmcgrath requested a review from a team as a code owner July 19, 2023 09:18
@vercel
Copy link

vercel bot commented Jul 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nextjs-auth0 ⬜️ Ignored (Inspect) Jul 19, 2023 9:30am

@adamjmcgrath adamjmcgrath added the review:small Small review label Jul 19, 2023
@adamjmcgrath adamjmcgrath merged commit 96d1234 into main Jul 19, 2023
@adamjmcgrath adamjmcgrath deleted the fix-cookie-chunked-smaller branch July 19, 2023 09:36
@adamjmcgrath adamjmcgrath mentioned this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refreshing token in API route - subsequent request returns 401 and clears session
2 participants