Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor params passed to logout over defaults #533

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

adamjmcgrath
Copy link
Contributor

Description

Additional parameters passed to logout should override the defaults, eg

router.get('/logout', (req, res) =>
      res.oidc.logout({ logoutParams: { id_token_hint: null } })
);

Should allow you to exclude the id_token_hint and force the logout prompt (or supply a logout_hint)

References

fixes #530

@adamjmcgrath adamjmcgrath requested a review from a team as a code owner November 2, 2023 13:47
@adamjmcgrath adamjmcgrath temporarily deployed to internal November 2, 2023 13:47 — with GitHub Actions Inactive
@adamjmcgrath adamjmcgrath temporarily deployed to internal November 2, 2023 13:47 — with GitHub Actions Inactive
@adamjmcgrath adamjmcgrath merged commit 86f5abf into master Nov 2, 2023
11 checks passed
@adamjmcgrath adamjmcgrath deleted the optional-logout-hint branch November 2, 2023 14:04
@adamjmcgrath adamjmcgrath mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow logout_hint instead of id_token_hint
2 participants