Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-3873] Discovery cache max age #449

Merged
merged 3 commits into from
Mar 16, 2023
Merged

Conversation

adamjmcgrath
Copy link
Contributor

Description

Currently the Discovery cache is in memory and permanent until the app is restarted.

Add logic to refresh it every so often so these can auto-heal if we have any bad configuration from the Discovery endpoint that is later corrected.

The default is 10mins and is configurable through the discoveryCacheMaxAge config (the Discovery endpoint is cached by cloudflare for 15 secs.)

@adamjmcgrath adamjmcgrath added the review:medium Medium review label Mar 15, 2023
@adamjmcgrath adamjmcgrath requested a review from a team as a code owner March 15, 2023 15:18
@adamjmcgrath adamjmcgrath merged commit f0ea1e5 into master Mar 16, 2023
@adamjmcgrath adamjmcgrath deleted the discovery-cache-max-age branch March 16, 2023 15:12
@adamjmcgrath adamjmcgrath mentioned this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:medium Medium review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants