Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-3887] Always honor auth0Logout config #447

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Conversation

adamjmcgrath
Copy link
Contributor

Description

The OIDC RP Initiated Logout endpoint is incompatible with Auth0's proprietary logout. Make sure this SDK does not use it if auth0Logout is configured and an end_session_endpoint is Discovered in the OIDC Discovery document.

Testing

If auth0Logout is true -> use v2/logout regardless of discovery
If auth0Logout is false -> use discovered endpoint or nothing
If auth0Logout is not set -> use v2/logout if issuer is auth0.com else discovered endpoint if available

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@adamjmcgrath adamjmcgrath added the review:medium Medium review label Mar 9, 2023
@adamjmcgrath adamjmcgrath requested a review from a team as a code owner March 9, 2023 14:41
@adamjmcgrath adamjmcgrath merged commit cf79490 into master Mar 10, 2023
@adamjmcgrath adamjmcgrath deleted the auth0-logout branch March 10, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:medium Medium review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants