[SDK-3911] Add support for providing a custom callback route #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewanharris
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+27
to
+33
| app.get('/login', (req, res) => | ||
| res.oidc.login({ | ||
| returnTo: '/profile', | ||
| authorizationParams: { | ||
| redirect_uri: 'http:https://localhost:3000/callback', | ||
| }, | ||
| }) |
Check failure
Code scanning / CodeQL
Missing rate limiting
ewanharris
commented
Jan 24, 2023
Co-authored-by: Adam Mcgrath <[email protected]>
ewanharris
force-pushed
the
feat/SDK-3911-custom-callback
branch
from
cc87d20
to
b404d06
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for providing a custom callback route similar to the existing support for a custom login and logout route. When providing this route, the
loginroute should always be provided so that theauthorizationParams.redirect_urivalue can be provided as this can no longer be inferred from config/defaults.The options for this accept a
tokenEndpointParamsthat is the same as the existing config option oftokenEndpointParams, just with the added benefit that these can be configured per request not just once for the app.Checklist