Use latest Gradle wrapper and Bump dependencies #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot to update this one on the past week.. This is good. But please, go and rollback the changes on |
lbalmaceda
suggested changes
Oct 29, 2018
lib/build.gradle
Outdated
| implementation 'com.auth0:jwks-rsa:0.6.1' | ||
| implementation 'com.fasterxml.jackson.core:jackson-databind:2.9.7' | ||
| implementation 'commons-codec:commons-codec:1.11' | ||
| implementation 'org.springframework.security:spring-security-core:5.1.1.RELEASE' |
There was a problem hiding this comment.
Suggested change
| implementation 'org.springframework.security:spring-security-core:5.1.1.RELEASE' | |
| implementation 'org.springframework.security:spring-security-core:4.2.9.RELEASE' |
lib/build.gradle
Outdated
| implementation 'com.fasterxml.jackson.core:jackson-databind:2.9.7' | ||
| implementation 'commons-codec:commons-codec:1.11' | ||
| implementation 'org.springframework.security:spring-security-core:5.1.1.RELEASE' | ||
| implementation 'org.springframework.security:spring-security-web:5.1.1.RELEASE' |
There was a problem hiding this comment.
Suggested change
| implementation 'org.springframework.security:spring-security-web:5.1.1.RELEASE' | |
| implementation 'org.springframework.security:spring-security-web:4.2.9.RELEASE' |
lib/build.gradle
Outdated
| implementation 'commons-codec:commons-codec:1.11' | ||
| implementation 'org.springframework.security:spring-security-core:5.1.1.RELEASE' | ||
| implementation 'org.springframework.security:spring-security-web:5.1.1.RELEASE' | ||
| implementation 'org.springframework.security:spring-security-config:5.1.1.RELEASE' |
There was a problem hiding this comment.
Suggested change
| implementation 'org.springframework.security:spring-security-config:5.1.1.RELEASE' | |
| implementation 'org.springframework.security:spring-security-config:4.2.9.RELEASE' |
lib/build.gradle
Outdated
| testImplementation 'junit:junit:4.12' | ||
| testImplementation 'org.hamcrest:java-hamcrest:2.0.0.0' | ||
| testImplementation 'org.mockito:mockito-core:2.23.0' | ||
| testCompile 'javax.servlet:javax.servlet-api:4.0.1' |
There was a problem hiding this comment.
Suggested change
| testCompile 'javax.servlet:javax.servlet-api:4.0.1' | |
| testCompile 'javax.servlet:servlet-api:2.5' |
lib/build.gradle
Outdated
| implementation 'org.springframework.security:spring-security-web:5.1.1.RELEASE' | ||
| implementation 'org.springframework.security:spring-security-config:5.1.1.RELEASE' | ||
| implementation 'org.slf4j:slf4j-api:1.7.25' | ||
| compileOnly 'javax.servlet:javax.servlet-api:4.0.1' |
There was a problem hiding this comment.
Suggested change
| compileOnly 'javax.servlet:javax.servlet-api:4.0.1' | |
| compileOnly 'javax.servlet:servlet-api:2.5' |
|
Gotcha, updated. |
lbalmaceda
reviewed
Oct 29, 2018
build.gradle
Outdated
| } | ||
|
|
||
| wrapper { |
There was a problem hiding this comment.
I've never needed this before. Can you safely remove it? How have you updated the gradle version? I normally run ./gradlew wrapper --gradle-version 4.10.2 --distribution-type all
lbalmaceda
approved these changes
Nov 22, 2018
lbalmaceda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.