Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config argument to loginWithPopup #77

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Conversation

Aulos
Copy link
Contributor

@Aulos Aulos commented Jul 30, 2020

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Auth0Client provides a second argument config for loginWithPopup function.

Unfortunately in auth0-react the second argument has been omitted.

Testing

This change just redirects config argument to Auth0Client so no testing is needed.

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Aulos Aulos requested a review from a team July 30, 2020 12:47
Copy link
Contributor

@adamjmcgrath adamjmcgrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Aulos

@adamjmcgrath adamjmcgrath merged commit caa2d09 into auth0:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants