Update Auth0-SPA-JS to latest version #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikprijck
temporarily deployed
to
internal
GitHub Actions
Inactive
frederikprijck
temporarily deployed
to
internal
GitHub Actions
Inactive
frederikprijck
temporarily deployed
to
internal
GitHub Actions
Inactive
frederikprijck
temporarily deployed
to
internal
GitHub Actions
Inactive
ewanharris
approved these changes
Dec 11, 2023
Merged
frederikprijck
added a commit
that referenced
this pull request
Dec 11, 2023
**Changed** - Update Auth0-SPA-JS to latest version [\#690](#690) ([frederikprijck](https://github.com/frederikprijck))
| @@ -96,6 +96,6 @@ | |||
| "react-dom": "^16.11.0 || ^17 || ^18" | |||
| }, | |||
| "dependencies": { | |||
| "@auth0/auth0-spa-js": "^2.1.2" | |||
| "@auth0/auth0-spa-js": "^2.1.3" | |||
There was a problem hiding this comment.
@frederikprijck This is causing issue for login. As we have set prompt and login which reset to none. It has issue during call of getAccessTokenSilently which saying error as 'Failed Silent Auth' and Login required
There was a problem hiding this comment.
I can't see how that would be caused by that version bump to SPA-JS. All we did was add additional functionality that is opt-in, see https://github.com/auth0/auth0-spa-js/releases/tag/v2.1.3.
If you believe it does, please open an issue demonstrating the behavior caused by the SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates SPA-JS to the latest version to add support for workerUrl.
References
https://github.com/auth0/auth0-spa-js/releases/tag/v2.1.3
Checklist