Support redirectUri again in a deprecated way #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikprijck
commented
Feb 16, 2023
src/auth0-provider.tsx
Outdated
| * @ignore | ||
| */ | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| function deprecateRedirectUri(options?: any) { |
There was a problem hiding this comment.
Went with any here as options.redirectUri does not exist on our types anymore.
frederikprijck
force-pushed
the
feat/sdk-3985
branch
2 times, most recently
from
e26f5a5
to
c2fb386
Compare
frederikprijck
force-pushed
the
feat/sdk-3985
branch
from
c2fb386
to
78e2f81
Compare
frederikprijck
force-pushed
the
feat/sdk-3985
branch
from
78e2f81
to
88790fc
Compare
ewanharris
previously approved these changes
Feb 16, 2023
3 tasks
ewanharris
approved these changes
Feb 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the release of Auth0-React v2, we have renamed redirectUri to redirect_uri and moved it into an authorizationParams property bag.
This has been called out multiple times to be problematic and causing bad DX, especially since the error logging on Auth0 server doesn't point in the correct direction.
We might want to add some deprecation strategy here to help people migrate instead, to ensure we increase DX again.
Note: this only patches the constructor and loginWithRedirect. All other methods in Auth0-React v1 were using
redirect_uriand never even supportedredirectUri.References
#506
Testing
Checklist