Avoid potential multiple invocations of loginWithRedirect

[kweiberth]

Resolves #309

[adamjmcgrath]

Could you remove this comment and instead add a regression test to with-authentication-required.test.tsx

Something like:

it('should only call login once when parent state changes', async () => {
    mockClient.getUser.mockResolvedValue(undefined);
    const MyComponent = (): JSX.Element => <>Private</>;
    const WrappedComponent = withAuthenticationRequired(MyComponent);
    const App = ({ foo }: { foo: number }): JSX.Element => (
      <div>
        {foo}
        <Auth0Provider clientId="__test_client_id__" domain="__test_domain__">
          <WrappedComponent />
        </Auth0Provider>
      </div>
    );
    const { rerender } = render(<App foo={1} />);
    await waitFor(() =>
      expect(mockClient.loginWithRedirect).toHaveBeenCalled()
    );
    mockClient.loginWithRedirect.mockClear();
    rerender(<App foo={2} />);
    await waitFor(() =>
      expect(mockClient.loginWithRedirect).not.toHaveBeenCalled()
    );
  });

[adamjmcgrath]

Thanks @kweiberth! Will do put up a release straight after the holidays

[kweiberth]

Thank you @adamjmcgrath! And thanks for writing out the test. All sounds good, happy holidays!

[GautamGupta]

Thanks!

[kevin19940627]

Hi there, withAuthenticationRequired seems to be invoking login multiple times with React 18 create react app. issues seem to appear when we use the new createRoot() API. is anyone experiencing the same issue?