[SDK-1697] Add custom user agent to spa js #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjmcgrath
added
small
adamjmcgrath
changed the title
stevehobbsdev
approved these changes
Jun 3, 2020
lbalmaceda
approved these changes
Jun 3, 2020
| expect.objectContaining({ | ||
| auth0Client: { | ||
| name: 'auth0-react', | ||
| version: pkg.version, |
There was a problem hiding this comment.
Shouldn't this have the env property with the node version here? I remember a recent discussion but not the outcome.
There was a problem hiding this comment.
This is a browser SDK so no node version, we should get the browser name and version from the User-Agent header
| @@ -110,6 +110,11 @@ export interface Auth0ProviderOptions extends PropsWithChildren<{}> { | |||
| [key: string]: any; // eslint-disable-line @typescript-eslint/no-explicit-any | |||
| } | |||
|
|
|||
| /** | |||
| * @ignore | |||
There was a problem hiding this comment.
Given that the doc block is already here, could we add a short description of what this value represents?
There was a problem hiding this comment.
Sure - I'll add a description in the docs PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
nameandversionuser agent details to pass toauth0-spa-jsReferences
auth0/auth0-spa-js#490
Testing
Checklist
master