[SDK-2603] Expose custom caching options from Auth0 SPA SDK #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
added
CH: Added
adamjmcgrath
previously approved these changes
Jul 6, 2021
stevehobbsdev
commented
Jul 7, 2021
__tests__/auth-provider.test.tsx
Outdated
| @@ -350,6 +350,7 @@ describe('Auth0Provider', () => { | |||
| act(() => { | |||
| result.current.logout({ localOnly: true }); | |||
| }); | |||
| await waitForNextUpdate(); | |||
There was a problem hiding this comment.
@adamjmcgrath Can you confirm if this is the way to handle this in the test? As the logout function is now async, I concluded that we'd need to wait until the next tick before asserting (it fails without this line).
There was a problem hiding this comment.
@stevehobbsdev logout needs to remain sync by default here as well - I added c874251
There was a problem hiding this comment.
Thanks for taking care of it 👍🏻
adamjmcgrath
approved these changes
Jul 8, 2021
adamjmcgrath
requested changes
Jul 8, 2021
adamjmcgrath
previously approved these changes
Jul 8, 2021
adamjmcgrath
approved these changes
Jul 8, 2021
|
Awesome work guys, been holding out for this one. Much appreciated! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades
@auth0/auth0-spa-jsto v1.16.0 and exposes the new custom cache option.References
https://github.com/auth0/auth0-spa-js/releases/tag/v1.16.0
auth0/auth0-spa-js#743
Testing
Checklist
master