Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-1641] Add SSR support #17

Merged
merged 4 commits into from
May 28, 2020
Merged

[SDK-1641] Add SSR support #17

merged 4 commits into from
May 28, 2020

Conversation

adamjmcgrath
Copy link
Contributor

@adamjmcgrath adamjmcgrath commented May 27, 2020 •
edited
Loading

Description

Bump auth0-spa-js so the library can be initialised in SSR builds like Next.js SPA mode. Also initialise the loading state as false because the library will never load any auth state in an SSR build.

References

auth0/auth0-spa-js#471

Testing

Tested in Gatsby and Next.js builds

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@adamjmcgrath adamjmcgrath added small This PR may require low effort to action, or contains few changes to review CH: Added PR is adding feature or functionality labels May 27, 2020
@adamjmcgrath adamjmcgrath changed the title Add SSR support [SDK-1641] Add SSR support May 27, 2020
@adamjmcgrath adamjmcgrath requested a review from a team May 28, 2020 08:53
@adamjmcgrath adamjmcgrath merged commit eff149a into master May 28, 2020
@adamjmcgrath adamjmcgrath deleted the ssr-support branch May 28, 2020 09:04
@acomito acomito mentioned this pull request Jan 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
CH: Added PR is adding feature or functionality small This PR may require low effort to action, or contains few changes to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamjmcgrath @stevehobbsdev