Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add react fast refresh support #151

Merged
merged 1 commit into from
Oct 28, 2020
Merged

fix: add react fast refresh support #151

merged 1 commit into from
Oct 28, 2020

Conversation

Idered
Copy link
Contributor

@Idered Idered commented Oct 28, 2020 •
edited
Loading

Description

React Fast Refresh is now used by default in Next.js 10. RFR require named components, otherwise it will reload whole page. This is a small fix that replaces unnamed arrow function with named function.

Testing

This can be tested by bootstraping next.js project and setting up this package. Wrapping any page export with withAuthenticationRequired should result in smooth content refresh after change.

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

Btw: it would be cool to get this accepted as hacktoberfest PR, thanks!

@Idered Idered requested a review from a team as a code owner October 28, 2020 16:43
@adamjmcgrath adamjmcgrath merged commit c3e50a1 into auth0:master Oct 28, 2020
@adamjmcgrath
Copy link
Contributor

Thanks @Idered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Idered @adamjmcgrath